ui: remove token contract address from ui to avoid confusion #3079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably this - #2974 (comment) ? |
JoeGruffins
approved these changes
Nov 13, 2024
|
As a seasoned DCRDEX user I can attest to that; I nearly shit my pants while checking my token balance and exploring the Polygon block explorer when I saw all of these transactions I neither recognised nor made myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could have sworn there was an issue opened for this, but I can't find it now. For tokens, the token address was shown in the wallet dialog. A user could potentially think the displayed address was their own address, and cause mass destruction. This removes the token contract address from the UI.